Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various linting issues #426

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fix various linting issues #426

merged 1 commit into from
Oct 10, 2023

Conversation

reedy
Copy link
Contributor

@reedy reedy commented Oct 5, 2023

No description provided.

@reedy
Copy link
Contributor Author

reedy commented Oct 5, 2023

Looks like it's just down to reduced test coverage, at least partly from the changes in #418. Nothing really exercising any of the Libbi code

 ---------- coverage: platform linux, python 3.9.18-final-0 -----------
Name                                          Stmts   Miss  Cover   Missing
---------------------------------------------------------------------------
custom_components/myenergi/__init__.py           63      7    89%   98-111, 116-117
custom_components/myenergi/binary_sensor.py      33      0   100%
custom_components/myenergi/config_flow.py        66      0   100%
custom_components/myenergi/const.py              17      0   100%
custom_components/myenergi/entity.py             58      0   100%
custom_components/myenergi/number.py            100      1    99%   26
custom_components/myenergi/select.py             95     10    89%   68, 147, 152, 159, 164-166, 170-171, 175
custom_components/myenergi/sensor.py            217     11    95%   494-648
---------------------------------------------------------------------------
TOTAL                                           649     29    96%

@CJNE CJNE merged commit 9a34460 into CJNE:main Oct 10, 2023
3 of 4 checks passed
@CJNE
Copy link
Owner

CJNE commented Oct 10, 2023

Thanks!

@reedy reedy deleted the octoberlinting branch October 10, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reedy @CJNE